Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to Next js #686 #689

Closed
wants to merge 2 commits into from
Closed

Migration to Next js #686 #689

wants to merge 2 commits into from

Conversation

anubhav2102
Copy link
Contributor

Migration to Next js fixing #686

Screenshot 2023-03-31 135838
Screenshot 2023-03-31 135857

Major Changes:

  1. File/folder structure
  2. Google analytics into /lib/gta.js
  3. Modification with react-plotly as per next.js docs.

@anubhav2102 anubhav2102 requested a review from suzil as a code owner March 31, 2023 08:45
@arunavabasucom
Copy link
Owner

Ahh !! Great 👍

@arunavabasucom arunavabasucom self-requested a review April 2, 2023 11:09
arunavabasucom
arunavabasucom reviewed Apr 2, 2023
View reviewed changes
Copy link
Owner

@arunavabasucom arunavabasucom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make use of new appdir and page layout of next js 13 !! test is falling we need to fix that in the next js way !! Although all things are perfect !!

@arunavabasucom arunavabasucom added 🚀 enhancement New feature or request 🏡 frontend frontend related stuff labels Apr 2, 2023
@anubhav2102 anubhav2102 closed this Apr 7, 2023
@anubhav2102 anubhav2102 reopened this Apr 7, 2023
@anubhav2102
Migrate to next js
e3033fe 
Signed-off-by: Anubhav <[email protected]>
@anubhav2102
Fix errors
1fd6095 
Signed-off-by: Anubhav <[email protected]>
@anubhav2102
Copy link
Contributor Author

Tests are working locally, implemented app dir for next.js 13, screenshots attached for reference.
Tests are getting stuck on CI workflow maybe due to CI configurations as per the sources.
@arunavabasu-03

Screenshot 2023-04-27 195339
Screenshot 2023-04-25 040339

@arunavabasucom
Copy link
Owner

@anubhav2102 thanks for this PR , for now closing the PR , keep contributing !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunavabasucom arunavabasucom arunavabasucom left review comments

@suzil suzil Awaiting requested review from suzil

Assignees

@anubhav2102 anubhav2102

Labels
🚀 enhancement New feature or request 🏡 frontend frontend related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anubhav2102 @arunavabasucom