feat(components): remove arc icon in favour of genorated phosphor icons #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicegginton
added
docs
This installs the @phosphor-icons/core package and adds it to the components package.json file.
Add script to generate icons from phosphor icons and remove arc icons. This is run as part of the build process of the components package. Refactors all components that use an arc icon to use the new phosphor based arc icons.
dominicegginton
force-pushed
the
ARC-30-update-icons
branch
from
c9aba08 to
312e32b
Compare
This renames the script to ph-icon-assemble to better reflect its scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add script to generate icons from phosphor icons and remove arc icons.
This is run as part of the build process of the components package.
Refactors all components that use an arc icon to use the new phosphor
based arc icons.