Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try updating GDAL #266

Closed
wants to merge 12 commits into from
Closed

Try updating GDAL #266

wants to merge 12 commits into from

Conversation

brynpickering
Copy link
Contributor

@Theodore-Chatziioannou was having problems on Windows with GDAL v3.6 but with this relatively strict dependency pinning we might be causing other downstream issues in https://github.com/arup-group/ersa/pull/56 so I'm trying out updating the pinning to skip v3.6 and seeing what the CI thinks about it.

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator.
All others should be checked by the reviewer(s).
You can add extra checklist items here if required by the PR.

  • CHANGELOG updated
  • Tests added to cover contribution
  • Documentation updated

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (07813c8) 86.84% compared to head (c32f41c) 87.57%.
Report is 161 commits behind head on main.

Files Patch % Lines
pam/planner/choice_location.py 80.85% 12 Missing and 6 partials ⚠️
pam/planner/utils_planner.py 76.59% 9 Missing and 2 partials ⚠️
pam/write/matsim.py 59.25% 6 Missing and 5 partials ⚠️
pam/read/diary.py 66.66% 6 Missing and 4 partials ⚠️
pam/optimise/grid.py 70.00% 9 Missing ⚠️
pam/vehicles.py 94.97% 4 Missing and 5 partials ⚠️
pam/core.py 87.87% 7 Missing and 1 partial ⚠️
pam/plot/plans.py 81.81% 3 Missing and 3 partials ⚠️
pam/optimise/random.py 71.42% 2 Missing and 2 partials ⚠️
pam/activity.py 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   86.84%   87.57%   +0.73%     
==========================================
  Files          49       48       -1     
  Lines        5496     5747     +251     
  Branches     1372     1374       +2     
==========================================
+ Hits         4773     5033     +260     
+ Misses        462      445      -17     
- Partials      261      269       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brynpickering
Copy link
Contributor Author

Segementation faults encountered in some Windows runs, so I'll return to this once this issue is resolved: OSGeo/gdal#8959

@brynpickering brynpickering marked this pull request as draft December 12, 2023 15:02
@brynpickering brynpickering deleted the update-gdal branch March 26, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants