Release lock if the originating process is gone #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix checks if the IP of the current machine is the same that the IP of the server that acquired the lock. if we are on the same machine, but the originating process doesn't exists anymore, it assumes we can safely release the lock and return false (aka, lock is not locked). Caveat : If the lock has been acquired by a process on pc-01, but the process failed to release the lock, no other machine will be able to acquire the same lock until a new process on pc-01 will call the isLocked() method again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix checks if the IP of the current machine is the same that the IP of the server that acquired the lock. if we are on the same machine, but the originating process doesn't exists anymore, it assumes we can safely release the lock and return false (aka, lock is not locked).
Caveat : If the lock has been acquired by a process on pc-01, but the process failed to release the lock, no other machine will be able to acquire the same lock until a new process on pc-01 will call the isLocked() method again.