Broke dependencies into /lib and added unit tests #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did end to end tests on Amazon S3 account this morning. Everything seems OK besides issue #31. |
|
What's the status on this? |
arvindr21
added a commit
that referenced
this pull request
Jan 12, 2015
Broke dependencies into /lib and added unit tests
|
Do you think we need to keep the |
|
Yes you can delete it. |
|
Ok, I will till that is done to push to NPM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only restructured the code into 3 files and added tests. I also checked that everything still worked with the full project.
Please check that everything is fine for Amazon S3.