Add experiment flag to pickle only on checkpoints #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyasapp
previously approved these changes
Jan 29, 2020
|
I would recommend adding logic for supporting torch as the protocol |
jeremyasapp
reviewed
Jan 30, 2020
| @@ -153,13 +155,19 @@ def _train(self) -> Dict: | |||
| def _save(self, checkpoint_dir: str) -> str: | |||
| """Subclasses should override this to implement save().""" | |||
| path = os.path.join(checkpoint_dir, "checkpoint.flambe") | |||
| self.block.save(path, pickle_only=self.pickle_checkpoints, overwrite=True) | |||
| if self.pickle_checkpoints: | |||
| torch.save(self.block, path, pickle_module=dill) | |||
There was a problem hiding this comment.
no overrite here?
Also still no way of selecting torch instead of dill?
jeremyasapp
deleted the
issue-223_pickle-experiment-chkpts_nmatthews-asapp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #223