Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change number parsing to treat 2. as a number #126

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

drlippman
Copy link
Contributor

As identified in issue #124, in the current parsing 2.3, 2 and .2 are treated as numbers, but 2. is treated as a number followed by an period operator. Since trailing decimal places can be used to indicate trailing zeros are significant, this behavior can cause valid numbers to not be treated as such.

However, this also means that if a end-of-sentence period follows a number, and that period is inside the asciimath area for some reason, that period would be treated as part of the number, which may not be desirable. But arguably this case would be caused by semantically incorrect markup, so perhaps isn't something we need to worry about.

@drlippman drlippman requested a review from jipsen February 7, 2021 03:56
@drlippman
Copy link
Contributor Author

@jipsen, since you understand the parsing grammar much better than me, it'd be great to get your thoughts of whether this would have any unintentional side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant