Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use curl instead of PHP to download installer #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use curl instead of PHP to download installer #141

wants to merge 1 commit into from

Conversation

combro2k
Copy link

@combro2k combro2k commented Nov 9, 2022

To fix issues to download composer-setup.php when using another openssl library I changed the php copy to curl

See #131

@combro2k combro2k requested a review from a team as a code owner November 9, 2022 10:14
@adaigre
Copy link

adaigre commented Nov 10, 2022

Another use case for this PR : cURL supports proxy env variables.
Native copy function in PHP doesn't work behind my company proxy.

@combro2k
Copy link
Author

@smorimoto looks like building failed due OpenSSL binding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smorimoto smorimoto smorimoto approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@combro2k @adaigre @smorimoto