Add PHP_ADDITIONAL_CONFIG_OPTIONS #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with default behavior
|
Is this plugin abandoned? This PR is a no-brainer that would allow us to fix a lot of issues ourselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding PHP_ADDITIONAL_CONFIG_OPTIONS to allow the user add custom build config options
to the script without changing default behavior.
Motivation: I had to mimic the build script to add a optional extension for
password_hash(PASSWORD_ARGON2ID)usage.If I had this option I only needed to do
PHP_ADDITIONAL_CONFIG_OPTIONS="--with-password-argon2" asdf install php latestto add that option