Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the README to resolve #10 #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

signus
Copy link

@signus signus commented May 9, 2023

Based on #10 the issue is itself not actually with the install but the instructions provided to install the ASDF plugin for R.

This is just a single line change in the README to resolve the message R is invalid. Name may only contain lowercase letters, numbers, '_', and '-':

asdf plugin-add r https://github.com/asdf-community/asdf-r.git

@signus signus requested a review from a team as a code owner May 9, 2023 16:57
@signus
Copy link
Author

signus commented May 9, 2023

Note that the hygiene check seems to be based on an outdated workflow that does not match with the current Makefile:

asdf-community/.github/.github/required-workflows/hygiene.yml

name: Hygiene

on:
  - pull_request

jobs:
  hygiene:
    name: Hygiene

    runs-on: ubuntu-latest

    steps:
      - name: Checkout code
        uses: actions/checkout@v3

      - name: Set-up Homebrew
        uses: Homebrew/actions/setup-homebrew@master

      # Dependencies
      - run: brew install shellcheck shfmt

      # Check formatting with shfmt
      - run: make format-check

      # Check linting with shellcheck
      - run: make lint

@flying-sheep
Copy link

flying-sheep commented Aug 22, 2023

You need to also fix the example lines here:

asdf-r/README.md

Lines 40 to 44 in f1e4b8b

```R_EXTRA_CONFIGURE_OPTIONS=--enable-R-shlib asdf install R <version>```
maibe you'll need Cairo as well:
```R_EXTRA_CONFIGURE_OPTIONS='--enable-R-shlib --with-cairo' asdf install R <version>```

Should be asdf install r, not R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants