Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add support for asdf >= 0.16 #590

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Dabolus
Copy link

@Dabolus Dabolus commented Feb 12, 2025

This PR adds support for asdf >= 0.16, which has been rewritten from scratch in Go and is no longer simply cloneable from git. It does so by downloading the pre-built release from GitHub for the correct platform and architecture.

The change adds support for a new optional parameter, asdf_version, which can be used to set a specific version to download and install. If not provided, the latest release will be downloaded by default.

I decided to add a new parameter because the existing one (asdf_branch) allows to specify not only a given version tag, but also any kind of branch. To support the same parameter with the rewritten asdf, the action should build asdf from source, but I don't think that's needed.

As of today, asdf_branch can be used to download the older, bash-based versions of asdf, so it's still possible to use the actions with those versions by simply adding e.g. asdf_branch: v0.15.0.

Note that, even though the older asdf versions are still downloadable using the parameter above, by default the new behavior is used, so this will most probably need a major version bump.

Let me know if the implementation makes sense and/or if I missed something.

Fixes #587

@Dabolus Dabolus requested a review from jthegedus as a code owner February 12, 2025 20:06
@Dabolus Dabolus changed the title Add support for asdf >= 0.16 feat!: add support for asdf >= 0.16 Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notice message about 0.16.0 asdf version
1 participant