Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Atmos by Cloud Posse #1042

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

osterman
Copy link

@osterman osterman commented Sep 5, 2024

Summary

Description:

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/<your_new_plugin_name>
  • Your plugin CI tests are green (see check)
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

@osterman osterman requested a review from a team as a code owner September 5, 2024 15:34
@osterman osterman changed the title Add Atmos by Cloud Posse feat: Add Atmos by Cloud Posse Sep 5, 2024
@osterman
Copy link
Author

@jthegedus anything else we need to do to get this merged? Thanks!

@jthegedus
Copy link
Contributor

@jthegedus anything else we need to do to get this merged? Thanks!

Nope, just a delay on my end. Thanks for your patience.

@jthegedus
Copy link
Contributor

@osterman Oh, actually, you will need to rebase as I do not have permissions to do that myself (I usually do on most PRs, must be a setting on your fork, how diligent of you! 😅 )

Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@osterman
Copy link
Author

Thanks @jthegedus - fixed the conflict. I think there's some setting in our GHE preventing the ability for you to update it. Thanks for letting me know!

@osterman osterman requested a review from jthegedus October 30, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants