Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web support for getting the server_auth_code field #1

Open
wants to merge 683 commits into
base: master
Choose a base branch
from

Conversation

hillelcoren
Copy link

Hi,

I found your repo from this comment, thanks for creating it!

flutter/flutter#57712 (comment)

In our app we needed to support getting the server_auth_code on the web, these changes fix this issue:

flutter/flutter#62474

ggirotto and others added 30 commits March 18, 2021 09:06
This ensures that the AUTHORS list is distributed with the plugins whose copyright blocks refer to the project authors, for ease of reference. This is currently a copy of the top-level authors list, but over time they are expected to diverge as people contribute to specific plugins.

This does not bump plugin versions or CHANGLELOGs, since it has no effect on the plugin itself; it will be picked up over time as we ship new versions of plugins.

Part of flutter/flutter#78448
- Replaces "the Flutter project authors" with the repo-standard version "The Flutter Authors"
  - Updates the license check not to allow "the Flutter project authors" in the future
- Fixes a few minor cosmetic variations that had crept back into LICENSE files since my
  mass-standardization of those files.
  - Updates the license check to validate those to prevent such drift in the future.
In all copyright messages (and in the Xcode project organization name) standardize on "The Flutter Authors", adding "The Chromium Authors" to the Flutter AUTHORS list. This reduces inconsistency in the copyright lines in this repository, moving closer to a single consistent copyright+license (as in flutter/engine and flutter/flutter)

Updates the validation script to no longer accept "The Chromium Authors" or "the Chromium project authors" in first-party code.
…ter#3723)

Updates integration_test README to note that the published version is deprecated and direct people to the SDK version.
Updates all plugins here to use the SDK version.
Standardizes all first-party copyrights on a single year, as is done in flutter/flutter and flutter/engine. All code now uses 2013, which is the earliest year that was in any existing copyright notice.

The script checks now enforce the exact format of first-party licenses and copyrights.

Fixes flutter/flutter#78448
This change enables the integration_tests of the following packages to run in Cirrus CI:

* google_sign_in_web
* connectivity_for_web
* google_maps_flutter_web
* url_launcher_web
…er#3735)

* Moved quickactions to a subfolder

* Added platform interface with tests

* Added exports

* Formatted, made initialize return Future<void> instead of void

* Fixed formatting

* formatting

* Fixed analyze issue with import

* Fixed formatting

* Fixed formatting

* Added license in files

* Removed accidental \\\

* changed license to Flutter 2017

* Moved quickactions to a subfolder

* Added platform interface with tests

* Added exports

* Formatted, made initialize return Future<void> instead of void

* Fixed formatting

* formatting

* Fixed analyze issue with import

* Fixed formatting

* Fixed formatting

* Added license in files

* Removed accidental \\\

* changed license to Flutter 2017

* Implemented feedback

* Changed 2017 to 2013

* Changed 2017 to 2013

* Implemented feedback.
* Use flutter gcp project for linux tasks.

Bug: flutter/flutter#77624

* Merge upstream changes and change cluster.

* Add test_script back.
* Fix iOS rotation issue

* Fix orientation issues on iOS

* Merged with master and added test

* Test RotationBox turns according to device orientation

* Fix formatting

* Removed merge conflict tags from CHANGELOG

* Fix license header in test
…r#3748)

* Add CUSTOM_ANALYSIS_PLUGINS back with all the plugins that now have a custom analysis_options.yaml
…n types (flutter#3754)

During the null-safety migration I accepted the auto-migrator use of as Future<T> to handle invokeMethod<T> returning a T?. I didn't realize that as does not actually do that kind of casting, and will fail with "type 'Future<T?>' is not a subtype of type 'Future<T>' in type cast".

There were no tests that exercised these methods in any way, so automated tests didn't catch the bug. This adds a minimal test that calls all of the non-void methods to ensure that they don't explode (and a TODO to backfill full unit tests of the entire method channel).

Fixes flutter/flutter#78426
Fixes flutter/flutter#78856
mvanbeusekom and others added 30 commits June 2, 2021 16:37
…ter#3945)

* Fixed code snippet in README

* Added button to restore purchases

* Updated CHANGELOG
- Moves XCTest files to the now-standard location
- Ensures that the harnesses are called RunnerTests for consistency
- Splits the image_picker unit tests out of the UI target into a new unit test target
- Moves existing google_sign_in tests into the harness, since they weren't being run.
  One new test, added since we accidentally stopped compiling the file, was removed
  since it crashed other tests in the suite (which has non-trivial global state, so fixing
  it wasn't feasible here; I've follow up on the PR that added the test).
- Removes the .cirrus.yml workaround that removed macOS podspecs before linting
- Deletes the dummy macOS podspecs that are no longer needed due to `flutter` fixes
- Adds --use-modular-headers to the lint command to reflect what Flutter Podfiles do
- Fix the actual issues in the podspecs
- Replaces most explicit use of `fileSystem` with path construction using the `child*` utility methods
- Removes explicit passing of a filesystem to the commands; we're already passing a `Directory` for the
  root where the tool operates, and we should never be using a different filesystem than that directory's
  filesystem, so passing it was both redundant, and a potential source of test bugs.
Eliminates the global test filesystem and global test packages directory, in favor of local versions. This guarantees that each test runs with a clean filesystem state, rather than relying on cleanup. It also simplifies understanding the tests, since everything is done via params and return values instead of needing to know about the magic global variables and which methods mutate them.
* Fix isMetadataAvailable bool

* Add unit test

* Update CHANGELOG and version
video_player was promoted to 1.0 a while ago, so should no longer have language in the README suggesting that it's in an unfinished/beta state.
Migrates:
- `all_plugins_app`
- `podspecs`
- `firebase-test-lab`

Minor functional changes to `firebase-test-lab` based on issues highlighted by the migration:
- The build ID used in the path is now a) passable, and b) given a fallback value in the path that
  isn't "null"
- Flag setup will no longer assume that `$HOME` must be set in the environment.
- Adds a --build-id flag to `firebase-test-lab` instead of hard-coding the use of  `CIRRUS_BUILD_ID`.
  The default is still `CIRRUS_BUILD_ID` so no CI changes are needed.

Part of flutter/flutter#81912
The plugins repo contributor's guide mostly defers to the main one, which it links to, but includes repository-specific information.

Also simplifies the section on style guides, while making it more comprehensive, by linking to the style section of the contributor guide.
Move all of the deprecated plugins to a secondary table, and replace
their extened pub info (points, popularity, likes) with pointers to the
replacement plugins.
- Adds macOS support to the `xctest` tool command
- Adds logic to the tool to check for packages that delegate their implementations
  to another package, so they can be skipped when running native unit tests
  - Updates the tool's unit test utility for writing pubspecs to be able to make
    delegated federated implementation references to test it
- Adds initial unit tests to the non-deprecated macOS plugins
- Enables macOS XCTesting in CI

macOS portion of flutter/flutter#82445
Uses "dev.flutter" rather than "io.flutter" for example application IDs on most platforms. Does not change Android since that may have more wide-reaching impact.

Also updates example copyrights on those platforms to the correct authorship.

Does not update versions on CHANGELOGs since this is an irrelevant-to-clients implementation detail of the example apps.

Part of flutter/flutter#31336
…utter#4037)

Migrates publish-check and version-check commands to NNBD.

Reworks the version-check flow so that it's more consistent with the other commands: instead of immediately exiting on failure, it checks all plugins, gathers failures, and summarizes all failures at the end. This ensures that we don't have failures in one package temporarily masked by failures in another, so PRs don't need to go through as many check cycles.

Part of flutter/flutter#81912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.