fix: update profile after edit profile

aseerkt · Aug 22, 2021 · 48055f6 · 48055f6 · vercel · Aug 22, 2021
1 parent eabf0a0
commit 48055f6
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 21 deletions.
diff --git a/client/src/generated/graphql.tsx b/client/src/generated/graphql.tsx
@@ -46,7 +46,7 @@ export type CreatePostResponse = {
 
 export type EditProfileResponse = {
   __typename?: 'EditProfileResponse';
-  ok: Scalars['Boolean'];
+  user?: Maybe<User>;
   errors?: Maybe<Array<FieldError>>;
 };
 
@@ -317,7 +317,7 @@ export type EditProfileMutationVariables = Exact<{
 }>;
 
 
-export type EditProfileMutation = { __typename?: 'Mutation', editProfile: { __typename?: 'EditProfileResponse', ok: boolean, errors?: Maybe<Array<{ __typename?: 'FieldError', path: string, message: string }>> } };
+export type EditProfileMutation = { __typename?: 'Mutation', editProfile: { __typename?: 'EditProfileResponse', user?: Maybe<{ __typename?: 'User', id: string, username: string, email: string, isFollowing: boolean, profile: { __typename?: 'Profile', id: string, name: string, website: string, bio: string, gender: string, imgURL: string, followersCount: number, followingsCount: number } }>, errors?: Maybe<Array<{ __typename?: 'FieldError', path: string, message: string }>> } };
 
 export type LoginMutationVariables = Exact<{
   username: Scalars['String'];
@@ -654,14 +654,16 @@ export const EditProfileDocument = gql`
     gender: $gender
     email: $email
   ) {
-    ok
+    user {
+      ...UserWithProfile
+    }
     errors {
       path
       message
     }
   }
 }
-    `;
+    ${UserWithProfileFragmentDoc}`;
 export type EditProfileMutationFn = Apollo.MutationFunction<EditProfileMutation, EditProfileMutationVariables>;
 
 /**

diff --git a/client/src/graphql/fragments/UserWIthProfile.graphql b/client/src/graphql/fragments/UserWIthProfile.graphql
diff --git a/client/src/graphql/mutations/editProfile.graphql b/client/src/graphql/mutations/editProfile.graphql
@@ -12,7 +12,9 @@ mutation EditProfile(
     gender: $gender
     email: $email
   ) {
-    ok
+    user {
+      ...UserWithProfile
+    }
     errors {
       path
       message

diff --git a/client/src/routes/EditProfile.tsx b/client/src/routes/EditProfile.tsx
@@ -1,7 +1,11 @@
 import Button from '../components-ui/Button';
 import Container from '../components-ui/Container';
 import InputField from '../components-ui/InputField';
-import { useEditProfileMutation, useMeQuery } from '../generated/graphql';
+import {
+  MeDocument,
+  useEditProfileMutation,
+  useMeQuery,
+} from '../generated/graphql';
 import ChangeProfilePhoto from '../components/ChangeProfilePhoto';
 import { Field, Form, Formik } from 'formik';
 import { useMessageCtx } from '../context/MessageContext';
@@ -42,18 +46,21 @@ const EditProfile: React.FC = () => {
             }}
             onSubmit={async (values, action) => {
               try {
-                const res = await editProfile({
+                await editProfile({
                   variables: values,
                   update: (cache, { data }) => {
                     if (data) {
-                      const { errors, ok } = data.editProfile;
+                      const { errors, user } = data.editProfile;
                       if (errors) {
                         errors.forEach(({ path, message }) => {
                           action.setFieldError(path, message);
                         });
                       }
-                      if (ok) {
-                        cache.evict({ id: cache.identify(user) });
+                      if (user) {
+                        cache.writeQuery({
+                          query: MeDocument,
+                          data: { me: user },
+                        });
                         setMessage('Profile updated');
                       }
                     }

diff --git a/server/src/resolvers/ProfileResolver.ts b/server/src/resolvers/ProfileResolver.ts
@@ -46,8 +46,8 @@ export class EditProfileArgs {
 
 @ObjectType()
 export class EditProfileResponse {
-  @Field()
-  ok: boolean;
+  @Field(() => User, { nullable: true })
+  user?: User;
   @Field(() => [FieldError], { nullable: true })
   errors?: FieldError[];
 }
@@ -158,21 +158,20 @@ export class ProfileResolver {
         const profileErrors = await validate(profile);
         if (userErrors.length > 0 || profileErrors.length > 0) {
           const errors = formatErrors([...userErrors, ...profileErrors]);
-          return { ok: false, errors };
+          return { errors };
         }
         await getManager().transaction(async (tem) => {
           await tem.save(user);
           await tem.save(profile);
         });
-        return { ok: true };
+        return { user };
       } catch (err) {
         console.log(err);
       }
     } else {
       console.log(profile, user);
     }
     return {
-      ok: false,
       errors: [{ path: 'unknown', message: 'Server Error' }],
     };
   }