Add removeEscapeCharFromText() function to 'base::string' #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while (int chr = decode.next()) { | ||
| if (chr == escapeChar) { | ||
| chr = decode.next(); | ||
| if (!chr) |
There was a problem hiding this comment.
warning: implicit conversion 'int' -> bool [readability-implicit-bool-conversion]
Suggested change
| if (!chr) | |
| if (chr == 0) |
| @@ -20,7 +20,9 @@ namespace base { | |||
|
|
|||
| std::string string_to_lower(const std::string& original); | |||
| std::string string_to_upper(const std::string& original); | |||
|
|
|||
| std::string removeEscapeCharFromText(const std::string& original, | |||
| const int escapeChar); | |||
There was a problem hiding this comment.
warning: parameter 'escapeChar' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
| const int escapeChar); | |
| int escapeChar); |
|
This function is too Aseprite-specific (mainly from the ui-lib). You can just add a function to ui (probably |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition is needed in the PR: aseprite/aseprite#4453 to solve issue: aseprite/aseprite#4387 (Duplicate shortcut key configuration items in Keyboard shortcuts)