Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate and consolidate config #58

Merged
merged 2 commits into from
Dec 7, 2023
Merged

validate and consolidate config #58

merged 2 commits into from
Dec 7, 2023

Conversation

gimmyxd
Copy link
Member

@gimmyxd gimmyxd commented Dec 6, 2023

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f72a6e1) 75.12% compared to head (4a64d69) 75.95%.

Files Patch % Lines
lib/directory/v3/null.ts 94.11% 2 Missing ⚠️
lib/directory/v3/index.ts 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   75.12%   75.95%   +0.83%     
==========================================
  Files          27       28       +1     
  Lines        1025     1069      +44     
  Branches      276      288      +12     
==========================================
+ Hits          770      812      +42     
- Misses        255      257       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gimmyxd gimmyxd requested review from ronenh and ogazitt December 6, 2023 11:57
@gimmyxd gimmyxd merged commit 4f92b88 into main Dec 7, 2023
4 checks passed
@gimmyxd gimmyxd deleted the consolideate_config branch December 7, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants