API Revisions #34
Merged
API Revisions #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertd
reviewed
Nov 8, 2024
config.go
Outdated
| // An Aserto tenant ID. | ||
| TenantID string `json:"tenant_id"` | ||
|
|
||
| // An aserto account ID. |
gertd
reviewed
Nov 8, 2024
ds/v2/directory.go
Outdated
| @@ -36,7 +36,7 @@ func New(opts ...aserto.ConnectionOption) (*Client, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| if options.ServerAddress() == "" { | |||
| if options.Address == "" { | |||
There was a problem hiding this comment.
You're right. I'll get rid of it.
gertd
reviewed
Nov 8, 2024
config.go
Outdated
| return nil, errors.Wrap(ErrInvalidConfig, "api_key and token are mutually exclusive") | ||
| } | ||
|
|
||
| if cfg.Insecure && cfg.NoTLS { |
There was a problem hiding this comment.
Do we need a mutually exclusive check for mTLS and (insecure | NoTLS)?
gertd
requested changes
Nov 8, 2024
gertd
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes breaking changes! It would be a minor version bump.o
SessionIDDialOptionsProviderand roll its functionality intoConnectionOptions.ConfiginConnectionOptionsto eliminate duplication.ConnectionOptions.WithClientCert().WithAccountIDand its equivalent config option.WithNoTLSand its equivalent config option.