Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checks context reason #122

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix checks context reason #122

merged 1 commit into from
Jan 28, 2025

Conversation

gertd
Copy link
Member

@gertd gertd commented Jan 28, 2025

Fix checks to align the context["reason"] result with check when identifiers are not found.

Before: checks would not return E20025 object not found: object <type>:<id> errors as part of the context["reason"] field, while the singleton version check, does return this information.

@gertd gertd requested a review from ronenh January 28, 2025 01:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13001862302

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 28.588%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/ds/check.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/directory/v3/reader.go 1 19.48%
Totals Coverage Status
Change from base Build 12939000933: 0.03%
Covered Lines: 990
Relevant Lines: 3463

💛 - Coveralls

@gertd gertd merged commit 3eb71b8 into main Jan 28, 2025
2 checks passed
@gertd gertd deleted the fix-checks-ctx branch January 28, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants