Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serviceName is not part of k8s deployment object #38

Merged
merged 1 commit into from
Feb 5, 2025
Merged

serviceName is not part of k8s deployment object #38

merged 1 commit into from
Feb 5, 2025

Conversation

mdarii
Copy link
Contributor

@mdarii mdarii commented Feb 5, 2025

This PR aims to solve the lint failure due the undefined serviceName parameter when persistence is not used

ronenh
ronenh approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@ronenh ronenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. serviceName is only defined for StatefulSets, not Deployments.
Thanks for the contribution!

@ronenh ronenh merged commit 1543a58 into aserto-dev:main Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenh ronenh ronenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdarii @ronenh