Merge pull request #237 from Yasasr1/v2.0.14-pre-release

Introduce client_id parameter to logout request
asgardeo · Oct 3, 2023 · 01822f0 · 01822f0
2 parents dfbdc8e + b811bc5
commit 01822f0
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 13 deletions.
diff --git a/lib/src/core/authentication-core.ts b/lib/src/core/authentication-core.ts
@@ -535,17 +535,7 @@ export class AuthenticationCore<T> {
             );
         }
 
-        const idToken = (await this._dataLayer.getSessionData(userID))?.id_token;
-
-        if (!idToken || idToken.trim().length === 0) {
-            throw new AsgardeoAuthException(
-                "JS-AUTH_CORE-GSOU-NF02",
-                "ID token not found.",
-                "No ID token could be found. Either the session information is lost or you have not signed in."
-            );
-        }
-
-        const callbackURL = configData?.signOutRedirectURL ?? configData?.signInRedirectURL;
+        const callbackURL: string = configData?.signOutRedirectURL ?? configData?.signInRedirectURL;
 
         if (!callbackURL || callbackURL.trim().length === 0) {
             throw new AsgardeoAuthException(
@@ -556,9 +546,24 @@ export class AuthenticationCore<T> {
             );
         }
 
-        const logoutCallback =
+        let parameter: string = `client_id=${ configData.clientID }`;
+
+        if (configData.sendIdTokenInLogoutRequest) {
+            const idToken: string = (await this._dataLayer.getSessionData(userID))?.id_token;
+
+            if (!idToken || idToken.trim().length === 0) {
+                throw new AsgardeoAuthException(
+                    "JS-AUTH_CORE-GSOU-NF02",
+                    "ID token not found.",
+                    "No ID token could be found. Either the session information is lost or you have not signed in."
+                );
+            }
+            parameter = `id_token_hint=${ idToken }`;
+        }
+
+        const logoutCallback: string =
             `${ logoutEndpoint }?` +
-            `id_token_hint=${ idToken }` +
+            parameter +
             `&post_logout_redirect_uri=${ callbackURL }&state=` +
             SIGN_OUT_SUCCESS_PARAM;
 

diff --git a/lib/src/models/client-config.ts b/lib/src/models/client-config.ts
@@ -40,6 +40,7 @@ export interface DefaultAuthClientConfig {
   *
   */
   sendCookiesInRequests?: boolean;
+  sendIdTokenInLogoutRequest?: boolean;
 }
 
 export interface WellKnownAuthClientConfig extends DefaultAuthClientConfig {
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,6 +40,7 @@ export interface DefaultAuthClientConfig { @@
       *
       */
       sendCookiesInRequests?: boolean;
+      sendIdTokenInLogoutRequest?: boolean;
     }
     export interface WellKnownAuthClientConfig extends DefaultAuthClientConfig {
@@ Expand Down @@