BREAKING CHANGE: Stop transforming custom auth params #209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses the issue reported in asgardeo/asgardeo-auth-react-sdk#208, where the keys passed into the
signIn
hook are transformed into Snake Case, causing compatibility issues.Fix was added to
@asgardeo/auth-js
and@asgardeo/auth-spa
version was bumped.Goals
Approach
The issue was introduced with the changes in asgardeo/asgardeo-auth-js-core#203. The approach involves reverting the specific change that introduced the undesired key transformation.
Before
After
User stories
signIn
hook without having the keys transformed.Release note
🔥 BREAKING CHANGE: Fixed an issue where custom parameters passed to the
signIn
hook were transformed into Snake Case, causing compatibility issues.Documentation
N/A (No documentation impact)
Training
N/A (No training impact)
Certification
N/A (No impact on certification exams)
Marketing
N/A (No marketing impact)
Automation tests
Security checks
Samples
N/A (No sample impact)
Related PRs
Migrations (if applicable)
N/A (No migration steps required)
Test environment
Tested on JDK versions, operating systems, databases, and browser/versions as follows:
Learning
The research phase involved an analysis of the introduced changes in asgardeo/asgardeo-auth-js-core#203.