Remove secureroute component and react-router dependency #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
SecureRouter
component in React SDK allows defining protected routes in a React app, when the used routing library is the React Router[1], but it isn't without its own complexities and tech debt introduced to the SDK.SecureRoute
has resulted in a tightly coupled integration with the React Router library.SecureRoute
component.Due to the above reasons, we are planning to remove
SecureRoute
component from the React SDK. Instead, we are adding example code snippets to the API documentation for securing app routes using several prominent routing libraries.Related Issues
react-router-dom
dependency #230[1] https://reactrouter.com/en/main
[2] https://gist.github.com/mjackson/d54b40a094277b7afdd6b81f51a0393f