Fix Asgardeo Java OIDC app redirection Issue #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChanikaRuchini
force-pushed
the
issue-9654
branch
from
efe3198 to
5a5c448
Compare
chamathns
reviewed
Mar 21, 2022
io.asgardeo.tomcat.oidc.agent/src/main/java/io/asgardeo/tomcat/oidc/agent/OIDCAgentFilter.java
Outdated
Show resolved
Hide resolved
chamathns
reviewed
Mar 21, 2022
io.asgardeo.tomcat.oidc.agent/src/main/java/io/asgardeo/tomcat/oidc/agent/OIDCAgentFilter.java
Show resolved
Hide resolved
ChanikaRuchini
force-pushed
the
issue-9654
branch
from
5a5c448 to
dd3928d
Compare
senthalan
reviewed
Mar 22, 2022
io.asgardeo.tomcat.oidc.agent/src/main/java/io/asgardeo/tomcat/oidc/agent/OIDCAgentFilter.java
Show resolved
Hide resolved
senthalan
approved these changes
Mar 22, 2022
senthalan
approved these changes
Mar 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves
With this fix
Add support for the target page redirection.
If a user tries to access another secured page (eg: app/myApp) without having an authenticated session with the IdP, the user is first prompted for authentication. Then upon successful authentication, the user is redirected to the original page he tried to access.
Improve the SDK to add a redirection page as a new configurable oidc app property. Then the customer can add his custom home page by configuring the property
homePage. when the application admin has configured this property, the user will always be redirected to the $homePage upon successful authentication regardless of which secured page the user tries to access.Merge after asgardeo/asgardeo-java-oidc-sdk#40