-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix onHover issue #91
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for awesomeshapes ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@ashutosh1919 , Please review once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@essofyany why background shapes are scattered all over the place? why did you set zIndex=unset
?
@Sachin-chaurasiya , @mohittk please don't merge until the shape positions are undone and the website looks same as the original one.
Hi there. in order to fix onHover issue which is caused by shape position (absolute/relative) also to its parent dimension, so to fix it I had to tweak other properties like z-index and suddenly this affects the positions of the shapes on the homepage. |
#85
Hi there I was working on this issue and I found out that to fix it I have to make some changes:
Please keep in mind that to change the color of Donut you have to change the border-color property and for CircleGrid you have to change the fill property and not the background.
For example: