Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #176

Closed
wants to merge 1 commit into from
Closed

initial commit #176

wants to merge 1 commit into from

Conversation

UdayVaidya
Copy link

No description provided.

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stark-tech-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 5:30pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@UdayVaidya
Copy link
Author

Pull Request Comment

Summary of Changes:

This pull request includes several improvements to the JavaScript code in script.js to enhance its robustness and maintainability:

  1. Variable Declarations:

    • Updated all variable declarations to use const or let instead of var to ensure proper scoping and prevent global namespace pollution.
  2. Element Existence Checks:

    • Added checks to ensure that elements exist before adding event listeners. This prevents potential runtime errors if any of the elements are not found in the DOM.
  3. Code Clarity:

    • Improved overall code clarity by ensuring consistent use of const for variables that do not change, making the code easier to read and understand.

These changes aim to improve the reliability of the code and prevent potential issues during execution. Please review the modifications and let me know if there are any questions or further adjustments needed.

@aslams2020
Copy link
Owner

Hi @UdayVaidya
Please read - #64
Please follow the guidelines and make an issue first, get assigned and then only raise the PR

@UdayVaidya UdayVaidya closed this Oct 5, 2024
@UdayVaidya
Copy link
Author

ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants