Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ CI / CD - run tests on every commit #690

Merged
merged 31 commits into from
Aug 19, 2024

Conversation

ElishaKay
Copy link
Collaborator

@ElishaKay ElishaKay commented Jul 19, 2024

a) We'll want to set all the relevant env vars in the Project Settings to be leveraged by our tests:

  • Retriever OS Vars
  • LLM Providers OS Vars

b) Need to think through the potential values passed into the GPTResearcher class:

  • report_type = ENUM
  • report_source = ENUM
    ...

Screen Shot 2024-07-19 at 13 02 31

@ElishaKay
Copy link
Collaborator Author

ElishaKay commented Jul 19, 2024

Looks like the free teir Github server is out of space based on the PR in my fork
Might be solved by making leaner dockerfiles for the tests. See:

Specifically, these optional llm-specific dependencies seem to be:

langchain-google-genai>=1,<2
langchain-groq>=0.1,<0.2
langchain_anthropic>=0.1,<0.2
langchain_mistralai>=0.1,<0.2
langchain_huggingface>=0.0.1,<0.1
langchain_together>=0.1,<0.2
langchain_cohere
langchain_google_vertexai
langchain_fireworks
langchain_aws

What if we conditionally install dependencies based on environment variables or comment out llm-specific dependencies by default? Seems we'll want to meditate on a solution

Screen Shot 2024-07-19 at 13 16 52

@ElishaKay ElishaKay changed the title after docker image is built by github pr, set env vars & run tests CI / CD - run tests on every commit Jul 23, 2024
@assafelovic
Copy link
Owner

@ElishaKay there's a conflict here, also can i move forward with merging this?

@ElishaKay ElishaKay requested a review from assafelovic August 16, 2024 10:59
@ElishaKay ElishaKay marked this pull request as draft August 16, 2024 11:00
@ElishaKay
Copy link
Collaborator Author

ElishaKay commented Aug 16, 2024

@ElishaKay there's a conflict here, also can i move forward with merging this?

@assafelovic, resolved conflicts now - correct - ready for merge (the Github variables on the repo level can always be added later)

Attaching here the required settings & screenshots on the github repo level for convenience:

Step 1: Within the repo, press the "Settings" tab
Step 2: Create a new environment named "tests" (all lowercase)
Step 3: Click into the "tests" environment & add environment secrets: TAVILY_API_KEY & OPENAI_API_KEY

Screen Shot 2024-07-28 at 9 00 19
Screen Shot 2024-07-28 at 9 02 55

If configured correctly, here's what the Github action should look like when opening a new PR or committing to an open PR:

Screen Shot 2024-07-28 at 8 57 02

@ElishaKay ElishaKay self-assigned this Aug 16, 2024
@ElishaKay ElishaKay marked this pull request as ready for review August 18, 2024 07:41
@ElishaKay ElishaKay changed the title CI / CD - run tests on every commit ✅ CI / CD - run tests on every commit Aug 19, 2024
@assafelovic assafelovic merged commit b7b24c0 into assafelovic:master Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants