Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the setup of traits #16

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

stevegrunwell
Copy link
Member

Instead of using @before fixture methods to reset the [private] properties that keep track of what's changed in each trait, set the property values directly.

Fixes #14.

Instead of relying on `@before` fixtures to reset the [private] property that is tracking what's changed in each trait, set the default value in the property definition.
@stevegrunwell stevegrunwell added bug Something isn't working code quality Improve the quality of the codebase labels Oct 29, 2020
@stevegrunwell stevegrunwell added this to the Version 0.2.0 milestone Oct 29, 2020
@stevegrunwell stevegrunwell merged commit e8a9571 into develop Oct 29, 2020
@stevegrunwell stevegrunwell deleted the fix/track-initialization-of-fixtures branch October 29, 2020 15:56
@stevegrunwell stevegrunwell mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality Improve the quality of the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protect against Runkit (re-)definitions happening before fixtures run
1 participant