Incluindo formulário do rodapé do site #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
May 31, 2018 19:12
- Proposta de HTML a ser aplicada - Primeiros estilos ao formulário
- Quando todos atributos estiverem preenchidos botão de submit deve ser habilitado para envio do contato
- Foi utilizado uma solução utilizando o Google App Scrips para envio do email, baseado nesse tutorial: https://github.com/dwyl/learn-to-send-email-via-google-script-html-no-server
gabrielpedepera
force-pushed
the
#20-footer-form-contact
branch
2 times, most recently
from
7e1f605
to
b671c2d
Compare
pedromanoel
suggested changes
Jun 4, 2018
_assets/css/footer.scss
Outdated
| @@ -12,6 +12,52 @@ | |||
| & > * + * { | |||
| margin-top: 1.5rem; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Acho que faz mais sentido mover esses estilos para o breakpoint do desktop, assim não precisamos fazer um display: none e fica de acordo com a abordagem mobile-first
_config.yml
Outdated
| @@ -33,6 +33,7 @@ contato: | |||
| telefone: (11) 3032-6032 | |||
| endereco_1: Rua Aspicuelta, 678, Vila Madalena | |||
| endereco_2: 05433-011 - São Paulo - SP | |||
| formulario_google_app_script: https://script.google.com/macros/s/AKfycbxtepCGgMK3p1e3KxGDx2pRow2rydS6jNMVGffU4Q/exec | |||
There was a problem hiding this comment.
Utilizar o app scripts da Vaga Lume
|
|
||
| // add form-specific values into the data | ||
| data.formDataNameOrder = JSON.stringify(fields); | ||
| data.formGoogleSheetName = form.dataset.sheet || "responses"; // default sheet name |
There was a problem hiding this comment.
Não acho que é necessário salvar no google sheets nesse momento, talvez possamos tirar esses dados do script.
gabrielpedepera
force-pushed
the
#20-footer-form-contact
branch
6 times, most recently
from
10a69c1
to
cb67300
Compare
pedromanoel
pushed a commit
that referenced
this pull request
Jun 18, 2018
commit fb0bfb6 Author: Gabriel Silva Pereira <[email protected]> Date: Mon Jun 18 10:28:08 2018 -0300 Incluindo formulário do rodapé do site (#38) * Adicionando formulário de contato no rodapé - Proposta de HTML a ser aplicada - Primeiros estilos ao formulário * Removendo placeholder quando input ou textarea está em foco * Esconder formulário em dispositivos com resolução <= 768px * Habilitar/Desabilitar botão de submit no formulário de contato - Quando todos atributos estiverem preenchidos botão de submit deve ser habilitado para envio do contato * Adicionando lógica para envio de e-mail - Foi utilizado uma solução utilizando o Google App Scrips para envio do email, baseado nesse tutorial: https://github.com/dwyl/learn-to-send-email-via-google-script-html-no-server * Habilitando honeypot no formulário * Removendo javascripts do HTML * Alterando helper para asset ao invés de js * Movendo javascript para diretórios js * Alterando cor para variável * Adicionando extensão ao arquivo javascript home * Corrigindo um pequendo de digitação * Movendo estilos para breakpoint do desktop * Movendo mixin * Removendo chamada do google sheet * Alterando formulário para envio de e-mail
pedromanoel
pushed a commit
that referenced
this pull request
Jun 25, 2018
This reverts commit fb0bfb6.
pedromanoel
pushed a commit
that referenced
this pull request
Jun 25, 2018
commit 5e5cf55 Author: Pedro Manoel Evangelista <[email protected]> Date: Mon Jun 25 20:01:24 2018 -0300 Revert "Incluindo formulário do rodapé do site (#38)" This reverts commit fb0bfb6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referente a tarefa #20
Formulário é exibido apenas em dispositivos com largura menor ou igual a 768px
Mobile:
Desktop:
