Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate Powerplant.set_dispatch_plan() #494

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RobbeSneyders
Copy link

Pull Request

Related Issue

Closes #493

Description

As detailed in the issue, the dispatch correction should not happen for every market.

The dispatch correction code is copied from Powerplant.execute_dispatch(). What remains after removing this is equivalent to BaseUnit.set_dispatch_plan(), so the whole method can be removed.

Changes Proposed

Remove duplicate Powerplant.set_dispatch_plan() method.

Testing

See minimal reproducible example in issue.

Checklist

Please check all applicable items:

  • Code changes are sufficiently documented (docstrings, inline comments, doc folder updates)
  • New unit tests added for new features or bug fixes
  • Existing tests pass with the changes
  • Reinforcement learning examples are operational (for DRL-related changes)
  • Code tested with both local and Docker databases
  • Code follows project style guidelines and best practices
  • Changes are backwards compatible, or deprecation notices added
  • New dependencies added to pyproject.toml
  • A note for the release notes doc/release_notes.rst of the upcoming release is included
  • Consent to release this PR's code under the GNU Affero General Public License v3.0

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.40%. Comparing base (caa46f7) to head (9d8a8d2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
- Coverage   76.48%   76.40%   -0.08%     
==========================================
  Files          49       49              
  Lines        6319     6295      -24     
==========================================
- Hits         4833     4810      -23     
+ Misses       1486     1485       -1     
Flag Coverage Δ
pytest 76.40% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Powerplant.set_dispatch_plan() is broken for multiple markets
1 participant