feat(revealjs): disable menu open button #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Sagi-Kazar <[email protected]>
astefanutti
approved these changes
Feb 2, 2023
Signed-off-by: Mark Sagi-Kazar <[email protected]>
|
Thanks! |
|
Thanks for quickly merging it! |
|
@astefanutti would you consider releasing a new version with this fix? Thanks! |
|
@sagikazarmark thanks for the reminder. I've just released version 3.6.0 that contains this fix. Thanks again! |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for denehyg/reveal.js-menu#99
When the RevealMenu plugin is enabled, there is a menu button on the printed slides.
This change disables that menu during printing.
This isn't necessarily the best possible solution, but since there is no "official" API for updating plugin configuration and the RevealMenu plugin does not expose any destroy or hide button API, this is the best alternative at the moment.