Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare ruff-action@v2 #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: prepare ruff-action@v2 #15

wants to merge 1 commit into from

Conversation

ilyvsc
Copy link

@ilyvsc ilyvsc commented Nov 18, 2024

Hi there!

I submitted a pull request before chartboost/ruff-action was archived, adding these changes some time ago. I updated everything, thinking you might want to consider this update.

Major changes

  • Added support for ruff latest version.
  • Added support for isolated mode for running ruff with default rulesets.
  • Added support for setting up ruff with project-specific specifications or rulesets from a pyproject.toml or ruff.toml files.

Credits

Special thanks to the following repositories for their influence:

- `args`: Arguments passed to Ruff. Use `ruff --help` to see available options. Default: `check`.
- `src`: Source to run Ruff. Default: `'.'`.
- `version`: The version of Ruff to use, e.g. "0.5.0". Default: `""`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `version`: The version of Ruff to use, e.g. "0.5.0". Default: `""`.
- `version`: The version of Ruff to use, e.g. `"0.5.0"`. Default: `""`.

This may help reinforce writing the version with quotes. As writing it without is a footgun (ie: 0.10 is actually 0.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants