Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ruff] Parenthesize fix when argument spans multiple lines for unnecessary-round (RUF057) #15703

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[ruff] Parenthesize fix when argument spans multiple lines for unnecessary-round (RUF057) #15703

wants to merge 4 commits into from
+120 −8

Conversation

dylwil3
Copy link
Collaborator

@dylwil3 dylwil3 commented Jan 24, 2025

As in the title. We also make the fix unsafe when the range of the call to round() intersects comments.

Closes #15598

@dylwil3 dylwil3 added bug Something isn't working fixes Related to suggested fixes for violations preview Related to preview mode features labels Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working fixes Related to suggested fixes for violations preview Related to preview mode features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUF057 fix introduces an error when the argument contains a newline
1 participant
@dylwil3