Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] Remove "test-only" attributes (PLW0101) #15709

Closed
wants to merge 3 commits into from
Closed

[pylint] Remove "test-only" attributes (PLW0101) #15709

wants to merge 3 commits into from

Conversation

InSyncWithFoo
Copy link
Contributor

@InSyncWithFoo InSyncWithFoo commented Jan 24, 2025 •
edited
Loading

Summary

Resolves #15707, reverts #15627.

Test Plan

cargo nextest run and cargo insta test.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser
Copy link
Member

MichaReiser commented Jan 24, 2025 •
edited
Loading

As explained by @dhruvmanila in the linked issue: This rule is intentionally a test rule. @dylwil3 plans to do some more testing before promoting it to preview.

@InSyncWithFoo InSyncWithFoo deleted the PLW0101 branch January 24, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_generate_json_schema failing as of 0.9.2
2 participants
@InSyncWithFoo @MichaReiser