Treat deprecated aliases as equivalent in marker algebra #9342
+49
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/lower
branch
from
d3a9b27
to
6d6b863
Compare
charliermarsh
force-pushed
the
charlie/lower-i
branch
from
46f51be
to
8a19335
Compare
charliermarsh
force-pushed
the
charlie/eval
branch
from
3602e09
to
47cb7a5
Compare
charliermarsh
force-pushed
the
charlie/lower-i
branch
from
8a19335
to
cb39ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies our lowered representation such that any deprecated aliases are treated as "the same" marker in the algebra.
So, for example, we now recognize that this is impossible, despite the marker names being different:
Similarly, we now recognize that this is just
sys_platform == 'win32', despite the presence of both markers: