Show an interpreter-focused message for --target and --prefix
#9373
+165
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Nov 23, 2024
| let implementation = python.implementation(); | ||
| let interpreter = python.interpreter(); | ||
|
|
||
| if dimmed { |
There was a problem hiding this comment.
Pretty clunky but like... in uv venv, we show this at full color, with cyan paths. In uv pip install, we show it dimmed. (This is largely preserving existing behavior, open to changing one of the two.)
charliermarsh
force-pushed
the
charlie/target-message
branch
from
24d6ef1
to
69c9255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With
uv pip install --targetand--prefix, we (1) should allow managed Pythons, and (2) should show a different message that's focused on the interpreter we selected, rather than the environment.