include git_member when getting metadata from cache #9388
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like some of the failing tests are the "too many requests" thing I alluded to in my comment on the issue |
|
Yeah I think something is up with that index. I should look into removing our dependency on it. |
charliermarsh
approved these changes
Nov 24, 2024
Could we set up a packse like the example given in the issue (see https://github.com/PhilipVinc/uvtest/tree/dab673b4ad5c6f1335c491baf49ad4965562e876)? Also, I generally am pretty clueless about uv's testing story (I know it's snapshot based, but that's about it) but would be eager to learn by writing some tests here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Include the
git_memberwhen fetching metadata from cache.h/t to @PhilipVinc for the suggested fix
Resolves #8887
Test Plan
Pending