Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure ORT lib location is known to cmake #358

Merged
merged 11 commits into from
Oct 9, 2024
Merged

Conversation

20DM
Copy link
Collaborator

@20DM 20DM commented Oct 8, 2024

To fix @mmcleod89's issue discussed on slack.

@20DM
Copy link
Collaborator Author

20DM commented Oct 8, 2024

Unclear why some of them failed, but we should probably anyway merge the Sopt PR first to have a consistent ORT setup in Cmake 🤔

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@20DM 20DM requested a review from tkoskela October 9, 2024 10:44
@tkoskela
Copy link
Contributor

tkoskela commented Oct 9, 2024

How many places can you hard-code your version in 😂

$ rg '3\.1\.0'
cmake_files/version.cmake
2:set(${PROJECT_NAME}_VERSION 3.1.0)

data/config/test_simulation_config.yaml
2:Version: 3.1.0

data/config/config.yaml
2:Version: 3.1.0

data/config/test_measurements_config.yaml
2:Version: 3.1.0

@20DM 20DM merged commit 2537a2b into development Oct 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants