Skip to content

Commit

Permalink
AIP-72: Remove redundant handling of AirflowException (apache#45505)
Browse files Browse the repository at this point in the history
  • Loading branch information
kaxil authored Jan 9, 2025
1 parent 9de80ab commit 92c72db
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions task_sdk/src/airflow/sdk/execution_time/task_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -490,13 +490,6 @@ def run(ti: RuntimeTaskInstance, log: Logger):
end_date=datetime.now(tz=timezone.utc),
)
# TODO: Run task failure callbacks here
except AirflowException:
# TODO: handle the case of up_for_retry here
log.exception("Task failed with exception")
msg = TaskState(
state=TerminalTIState.FAILED,
end_date=datetime.now(tz=timezone.utc),
)
except AirflowTaskTerminated:
# External state updates are already handled with `ti_heartbeat` and will be
# updated already be another UI API. So, these exceptions should ideally never be thrown.
Expand Down

0 comments on commit 92c72db

Please sign in to comment.