Default tooltips to showArrow (apache#45468)

astronomer · Jan 7, 2025 · df16572 · df16572
1 parent c2ab839
commit df16572
Show file tree

Hide file tree

Showing 10 changed files with 13 additions and 10 deletions.
diff --git a/airflow/ui/src/components/DagRunInfo.tsx b/airflow/ui/src/components/DagRunInfo.tsx
@@ -71,7 +71,6 @@ const DagRunInfo = ({
           </Text>
         </VStack>
       }
-      showArrow
     >
       <HStack fontSize="sm">
         <Time datetime={dataIntervalStart} showTooltip={false} />

diff --git a/airflow/ui/src/components/TaskInstanceTooltip.tsx b/airflow/ui/src/components/TaskInstanceTooltip.tsx
@@ -50,7 +50,6 @@ const TaskInstanceTooltip = ({ children, taskInstance }: Props) => (
       },
       placement: "bottom-start",
     }}
-    showArrow
   >
     {children}
   </Tooltip>

diff --git a/airflow/ui/src/components/ui/Tooltip.tsx b/airflow/ui/src/components/ui/Tooltip.tsx
@@ -29,7 +29,16 @@ export type TooltipProps = {
 } & ChakraTooltip.RootProps;
 
 export const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>((props, ref) => {
-  const { children, content, contentProps, disabled, portalled, portalRef, showArrow, ...rest } = props;
+  const {
+    children,
+    content,
+    contentProps,
+    disabled,
+    portalled,
+    portalRef,
+    showArrow = true,
+    ...rest
+  } = props;
 
   if (disabled) {
     return children;

diff --git a/airflow/ui/src/pages/Dag/Header.tsx b/airflow/ui/src/pages/Dag/Header.tsx
@@ -63,7 +63,7 @@ export const Header = ({
       <SimpleGrid columns={4} gap={4} my={2}>
         <Stat label="Schedule">
           {Boolean(dag?.timetable_summary) ? (
-            <Tooltip content={dag?.timetable_description} showArrow>
+            <Tooltip content={dag?.timetable_description}>
               <Text fontSize="sm">
                 <FiCalendar style={{ display: "inline" }} /> {dag?.timetable_summary}
               </Text>

diff --git a/airflow/ui/src/pages/DagsList/DagCard.tsx b/airflow/ui/src/pages/DagsList/DagCard.tsx
@@ -41,7 +41,7 @@ export const DagCard = ({ dag }: Props) => {
     <Box borderColor="border.emphasized" borderRadius={8} borderWidth={1} overflow="hidden">
       <Flex alignItems="center" bg="bg.muted" justifyContent="space-between" px={3} py={2}>
         <HStack>
-          <Tooltip content={dag.description} disabled={!Boolean(dag.description)} showArrow>
+          <Tooltip content={dag.description} disabled={!Boolean(dag.description)}>
             <Link asChild color="fg.info" fontWeight="bold">
               <RouterLink to={`/dags/${dag.dag_id}`}>{dag.dag_display_name}</RouterLink>
             </Link>

diff --git a/airflow/ui/src/pages/DagsList/DagTags.tsx b/airflow/ui/src/pages/DagsList/DagTags.tsx
@@ -48,7 +48,6 @@ export const DagTags = ({ hideIcon = false, tags }: Props) =>
               ))}
             </VStack>
           }
-          showArrow
         >
           <Text>, +{tags.length - MAX_TAGS} more</Text>
         </Tooltip>

diff --git a/airflow/ui/src/pages/DagsList/RecentRuns.tsx b/airflow/ui/src/pages/DagsList/RecentRuns.tsx
@@ -70,7 +70,6 @@ export const RecentRuns = ({
             },
             placement: "bottom-start",
           }}
-          showArrow
         >
           <Link to={`/dags/${run.dag_id}/runs/${run.dag_run_id}/`}>
             <Box p={1}>

diff --git a/airflow/ui/src/pages/DagsList/Schedule.tsx b/airflow/ui/src/pages/DagsList/Schedule.tsx
@@ -28,7 +28,7 @@ type Props = {
 
 export const Schedule = ({ dag }: Props) =>
   Boolean(dag.timetable_summary) && dag.timetable_description !== "Never, external triggers only" ? (
-    <Tooltip content={dag.timetable_description} showArrow>
+    <Tooltip content={dag.timetable_description}>
       <Text fontSize="sm">
         <FiCalendar style={{ display: "inline" }} /> {dag.timetable_summary}
       </Text>

diff --git a/airflow/ui/src/pages/Dashboard/Health/HealthSection.tsx b/airflow/ui/src/pages/Dashboard/Health/HealthSection.tsx
@@ -44,7 +44,6 @@ export const HealthSection = ({
         </div>
       }
       disabled={!Boolean(latestHeartbeat)}
-      showArrow
     >
       <Tag
         borderColor={status === "healthy" ? "success.100" : "error.100"}

diff --git a/airflow/ui/src/pages/Dashboard/Health/HealthTag.tsx b/airflow/ui/src/pages/Dashboard/Health/HealthTag.tsx
@@ -48,7 +48,6 @@ export const HealthTag = ({
         </div>
       }
       disabled={!Boolean(latestHeartbeat)}
-      showArrow
     >
       <Tag borderRadius="full" colorPalette={status === "healthy" ? "green" : "red"} size="lg">
         <TagLabel>{title}</TagLabel>
-Original file line number
+Diff line change
@@ Expand Up / @@ -44,7 +44,6 @@ export const HealthSection = ({ @@
             </div>
           }
           disabled={!Boolean(latestHeartbeat)}
-          showArrow
         >
           <Tag
             borderColor={status === "healthy" ? "success.100" : "error.100"}
@@ Expand Down @@