Catalogtabs #572
Catalogtabs #572
Conversation
…tching data that does not exist
| } | ||
|
|
||
| // Handler function for updating GradesInfoCard on hover with single course | ||
| function updateGraphHover(data:any) { |
There was a problem hiding this comment.
Lets learn what these types are or atleast attempt to understand the shape of the data so we can get better type safety. There shouldn't be any any types anywhere.
There was a problem hiding this comment.
I'm going to leave this one as this came with the old Graphs component. I just copy pasted
| if (tab == 0) { | ||
| return ( | ||
| <> | ||
| <nav className={styles.tabContainer}> |
There was a problem hiding this comment.
We can refactor the code such that this nav isn't being duplicated in the code
There was a problem hiding this comment.
not 100% how to do this
|
|
||
| const gradePath = legacyId ? `/grades/0-${legacyId}-all-all` : `/grades`; | ||
|
|
||
| const [hoveredClass, setHoveredClass] = useState<any>(false); |
There was a problem hiding this comment.
Perhaps we can work on the grades chart itself to handle this sort of hovering functionality. Not sure
| }, [enrollContext]) | ||
|
|
||
| useEffect(() => { | ||
| if (course !== null) { |
There was a problem hiding this comment.
lets prefer !course and use && to condense the if statements
There was a problem hiding this comment.
not sure how to do this either
|
If you install |
…catalogtabs dealing with merge conflicts
|
See #637. |
No description provided.