Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support #30

Merged
merged 105 commits into from
Jun 12, 2019
Merged

Docker support #30

merged 105 commits into from
Jun 12, 2019

Conversation

pnmcosta
Copy link
Contributor

Please note this PR includes all the changes on #29 as well, so you can accept only this one if you're ok with the other one.

More info about the docker integration here: https://github.com/pnmcosta/saas-boilerplate/wiki/Changes-on-docker-support-branch but the readme as also been updated.

@pnmcosta pnmcosta mentioned this pull request Jun 12, 2019
@tima101
Copy link
Member

tima101 commented Jun 12, 2019

@pnmcosta I tested tests and starting app with a new way of passing env vars - works properly.

Haven't tested Docker but will merge anyway, will test after merging.

Thanks for making a lot of improvements, I think they are all great.


I will update sections related to env vars and Docker in project's README.

@tima101 tima101 merged commit 29743c2 into async-labs:master Jun 12, 2019
@pnmcosta
Copy link
Contributor Author

awesome, glad I could help and learn at the same time :)

I've got a microsoft graph oauth implementation on the oauth-azure (named it wrong!) but it does change the mongo database schema for users, as it now encrypts the tokens using https://github.com/wheresvic/mongoose-field-encryption so it maybe a breaking change to those that already use the boilerplate.

I'll write up some more details on the wiki, and if you'd like I can also PR it.

@tima101
Copy link
Member

tima101 commented Jun 12, 2019

@pnmcosta We already have two ways to authenticate. I suggest just keeping current two: google oauth and passwordless.

@pnmcosta
Copy link
Contributor Author

Yup, got it, I'll keep the branch cause I'll need it for something i'm working on.

@pnmcosta pnmcosta deleted the docker-support branch June 13, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants