ci: set output has been updated to use GITHUB_OUTPUT #1726 #1727
Conversation
resolved set-output command depreciation
updated the blog section
SumantxD
requested review from
thulieblack,
quetzalliwrites,
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1727--asyncapi-website.netlify.app/ |
pages/blog/automated-releases.md
Outdated
| run: echo "::set-output name=version::$(npm run get-version --silent)" | ||
| run: | | ||
| npm run get-version --silent | ||
| echo "version=$(npm run get-version --silent)" >> $GITHUB_ENV |
There was a problem hiding this comment.
Nicely done @SumantxD
Was just wondering if that should be $GITHUB_ENV or $GITHUB_OUTPUT. Maybe the later one should be there.
Additionally, I think the command npm run get-version --silent is redundant here 🛩️
removed redundancy and fixed _ENV to _OUTPUT
|
I would suggest wait for @derberg to come back from holidays, he is the better person who knows whether he wants this or not 😄 |
|
@SumantxD thanks! ok, so this PR do not close the related issue |
derberg
changed the title
|
@anshgoyalevil and thanks for making it easier and helping in review 🙏🏼 |
|
@thulieblack please approve as one change is related to old article, you need to approve that change 🙏🏼 |
|
/rtm |
|
@allcontributors please add @SumantxD for infra |
|
I've put up a pull request to add @SumantxD! 🎉 |
|
@allcontributors please add @anshgoyalevil for review |
|
I've put up a pull request to add @anshgoyalevil! 🎉 |
|
Thanks, @derberg for the tag. 🚀 |
as set-output is about to depreciate i have updated it with the latest format to use GITHUB_OUTPUT environment file.