Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix actor generation template #2067

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix actor generation template #2067

merged 1 commit into from
Oct 19, 2023

Conversation

AlexeyRokhin
Copy link
Contributor

Description

Fixes actor creation issue when additional parameters for GetClusterKind<T> are provided.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@AlexeyRokhin AlexeyRokhin marked this pull request as ready for review October 19, 2023 16:39
@AlexeyRokhin
Copy link
Contributor Author

Hi @rogeralsing
Could you please review this PR?

@rogeralsing
Copy link
Contributor

This makes total sense! awesome, merging!

@rogeralsing rogeralsing merged commit 55d06bb into asynkron:dev Oct 19, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeyRokhin @rogeralsing