Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore OperationCanceledException in SafeTask #2140

Conversation

mugu-1
Copy link
Contributor

@mugu-1 mugu-1 commented Nov 7, 2024

Description

Added a catch block for OperationCanceledException to ensure it is ignored and not logged, similar to the existing handling of TaskCanceledException. This change prevents logging of expected cancellation exceptions, reducing noise in the logs.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2024

CLA assistant check
All committers have signed the CLA.

@rogeralsing rogeralsing merged commit 87f19b1 into asynkron:dev Nov 7, 2024
18 checks passed
@mugu-1 mugu-1 deleted the SafeTask-Stop-Logging-OperationCanceledException branch November 8, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants