-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add heater of Large Home Appliances #152
Conversation
fyi, I tweaked the divide by 10 for the current temperature based on the max of the target_temperature. If it's above 100, I expect the value to be dived by 10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, just the bitmap one left! I do also like to remove the mode completely for now.
Co-authored-by: Bob van de Vijver <[email protected]>
Co-authored-by: Bob van de Vijver <[email protected]>
Co-authored-by: Bob van de Vijver <[email protected]>
Co-authored-by: Bob van de Vijver <[email protected]>
Co-authored-by: Bob van de Vijver <[email protected]>
Co-authored-by: Bob van de Vijver <[email protected]>
Co-authored-by: Bob van de Vijver <[email protected]>
Co-authored-by: Bob van de Vijver <[email protected]>
@bogguard Looks you made a mistake with the rebase, can you solve that? |
0e3ee67
to
db13b2f
Compare
@bobvandevijver , cleaned up the current PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Just some feedback on storing the fault labels.
@JELoohuis , tweaked the fault labels so they are now within the store and have a default fallback value when no specification is available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bogguard Great work and thank you for making all requested updates each time! I do hope our comments on the PR weren't frustrating you too much (I know I might have become frustrated), but I do know that you can now say you have made a great contribution to this app 👍🏻
Adds support to include small and large heater instance.
Device and Specification :