Fixed sensor reset #160
Merged
Fixed sensor reset #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobvandevijver
requested changes
Aug 16, 2024
This was referenced Aug 20, 2024
bobvandevijver
force-pushed
the
fix-sensor-reset
branch
from
d96a8b9
to
5ea1284
Compare
|
@JELoohuis I added a initialiser for the alarms when not set, or to reset them when the app is started and the configured timeout setting is set. Seems to work great with the motion sensor devices I have here. |
bobvandevijver
approved these changes
Aug 27, 2024
bobvandevijver
force-pushed
the
fix-sensor-reset
branch
from
fbfb218
to
abddb72
Compare
|
Rebased again: I moved the tamper alarm implementation to #187, but kept the alarm initialisation updates here. |
…h timeout setting active
bobvandevijver
force-pushed
the
fix-sensor-reset
branch
from
abddb72
to
9218358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Fixed sensor reset
Some sensors never send an end signal, leaving the alarm perpetually triggered.
A setting has been added to allow timeouts to end sensor alarms without an end signal.
This setting is automatically set when adding motion or smoke sensors based on their specification.
Since contact sensors use a boolean it is not possible to do this.