Add sensor alarm settings #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JELoohuis
force-pushed
the
add-sensor-alarm-settings
branch
from
8d4212b
to
8962156
Compare
Merged
JELoohuis
force-pushed
the
add-sensor-alarm-settings
branch
from
8962156
to
b8c115d
Compare
Merged
bobvandevijver
approved these changes
Sep 25, 2024
bobvandevijver
approved these changes
Sep 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added alarm settings to sensors
Smoke alarm devices now have support for the following Tuya capabilities as settings:
As well as alarm_switch as a regular capability (onoff.alarm_switch)
Since these are used by other sensors that are yet to be added the implementation has been done in the general sensor classes.