Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heater #37

Merged
merged 10 commits into from
Aug 8, 2024
Merged

Add heater #37

merged 10 commits into from
Aug 8, 2024

Conversation

JELoohuis
Copy link
Collaborator

@JELoohuis JELoohuis commented Jul 6, 2024

  • Added support for the heater category of devices.
    Since my test device had limited functionality the following capabilities were implemented and tested:

    • onoff (switch)
    • target_temperature (temp_set)
    • measure_temperature (temp_current)
    • measure_power (work_power)

    The eco-mode (mode_eco) and child_lock (lock) capability were added untested,
    so it would be nice to get feedback on them from users with devices that support them.

    The level instruction could not be tested and was not added,
    as it is unclear whether all devices that support it use all three levels,
    which would dictate the type of Homey capability used.

May resolve:

@MerelHudepohl
Copy link
Contributor

@JELoohuis i'm gonna put this in test so we might get some feedback. Once the icons are available please add them.

@MerelHudepohl MerelHudepohl requested review from jeroenwienk and wouter-athom and removed request for jeroenwienk July 12, 2024 12:06
@bobvandevijver bobvandevijver added the enhancement New feature or request label Jul 22, 2024
This was linked to issues Jul 24, 2024
@bobvandevijver bobvandevijver added this to the Release 1.2.0 milestone Jul 29, 2024
@JELoohuis JELoohuis force-pushed the add-heater branch 2 times, most recently from 3ee6dc2 to d6bd5fb Compare August 2, 2024 11:38
@bobvandevijver bobvandevijver linked an issue Aug 6, 2024 that may be closed by this pull request
@JELoohuis JELoohuis force-pushed the add-heater branch 3 times, most recently from 915a9c8 to 4608ce4 Compare August 8, 2024 12:05
@JELoohuis JELoohuis marked this pull request as ready for review August 8, 2024 12:14
@bobvandevijver bobvandevijver merged commit 8a8e2d2 into athombv:master Aug 8, 2024
1 check passed
@bobvandevijver bobvandevijver deleted the add-heater branch August 8, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Wall infrared Heater Request Device: Action Infrared panel heater Request Device: Heater
4 participants