-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add heater #37
Merged
Merged
Add heater #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@JELoohuis i'm gonna put this in test so we might get some feedback. Once the icons are available please add them. |
This was
linked to
issues
Jul 24, 2024
Closed
3ee6dc2
to
d6bd5fb
Compare
Closed
bobvandevijver
requested changes
Aug 7, 2024
915a9c8
to
4608ce4
Compare
bobvandevijver
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the heater category of devices.
Since my test device had limited functionality the following capabilities were implemented and tested:
The eco-mode (mode_eco) and child_lock (lock) capability were added untested,
so it would be nice to get feedback on them from users with devices that support them.
The level instruction could not be tested and was not added,
as it is unclear whether all devices that support it use all three levels,
which would dictate the type of Homey capability used.
May resolve: