Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dimmer #46

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Add dimmer #46

merged 6 commits into from
Aug 8, 2024

Conversation

JELoohuis
Copy link
Collaborator

@JELoohuis JELoohuis commented Jul 17, 2024

  • Added support for the dimmer category of devices.
    The following capabilities were implemented and tested:

    • onoff (switch_led_1, switch_led_2)
    • dim (bright_value_1, bright_value_2)

    The onoff is handled the same as in sockets, with 1 channel devices using the default capability,
    and 2 channel devices using it to turn both channels on/off, with sub-capabilities for the separate channels.

    In 2 channel devices the default dim capability is removed in favor of just sub-capabilities.

    The following settings were implemented and tested:

    • Minimum brightness (brightness_min_1, brightness_min_2)
    • Maximum brightness (brightness_max_1, brightness_max_2)
    • Bulb type (led_type_1, led_type_2)

    The work_mode instruction could not be tested and was not added.

drivers/dimmer/device.js Outdated Show resolved Hide resolved
drivers/dimmer/device.js Outdated Show resolved Hide resolved
drivers/dimmer/device.js Outdated Show resolved Hide resolved
drivers/dimmer/device.js Outdated Show resolved Hide resolved
drivers/dimmer/device.js Outdated Show resolved Hide resolved
drivers/dimmer/device.js Outdated Show resolved Hide resolved
drivers/dimmer/driver.js Outdated Show resolved Hide resolved
drivers/dimmer/device.js Outdated Show resolved Hide resolved
drivers/dimmer/driver.js Outdated Show resolved Hide resolved
drivers/dimmer/driver.js Outdated Show resolved Hide resolved
@bobvandevijver bobvandevijver linked an issue Aug 7, 2024 that may be closed by this pull request
@JELoohuis JELoohuis marked this pull request as ready for review August 8, 2024 10:53
@bobvandevijver bobvandevijver merged commit 20b9417 into athombv:master Aug 8, 2024
1 check passed
@bobvandevijver bobvandevijver deleted the add-dimmer branch August 8, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants