-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common Settings Page Layout #3174
Comments
All good with respect of aesthetics. One very important technical requirement is that users needs to understand how a certain parameter is set. For instance, if the user sets the keyscheme to |
Yes, we've been thinking of a good way to show the "current state" of a setting. |
Well, I think that |
An alternative simpler solution would be to make it all a form and add a "Save" button in the end. This way, we allow one to change their mind when configuring Nyxt and only save/apply the final state of the config, instead of adding lots of intermediate ones.
|
@aadcg I agree. The radio buttons and checkboxes are pretty good indicators on their own. We just need something like that for the other settings as well. We already put that in the spec for @aartaka's suggestion is interesting. I'm not sure if it's a direct solution for the issue, but it might help. Still, some settings lend themselves very well to a |
Re-iterating for the sake of clarity: if a parameter's default is tomato and the user as sets it to potato, then the next time they go to |
@aadcg Then we have a feild to show active modes for the |
Plaintext for copypasta:Note that some settings may require restarting Nyxt to take effect. The default keybinding scheme is always present, and CUA bindings will be familiar to many users. For individual buffers - keyschemes can be toggled with the (toggle-modes) command. For a persistent keyscheme each time you start Nyxt - make a selection here. Themes for the browser interface, panel buffers, and internal Nyxt pages like manual, bindings, and common settings. Select Default Web to view webpages as they are designed. Select Darkened Web to have Nyxt darken arbitrary webpages you visit, by default. To darken an individual webpage, use the command (dark-mode). Incremental changes advised. Choose your homepage. By default your homepage is set to the internal Nyxt page (nyxt:new) Choose your starting point when launching Nyxt. Specify default modes for all new buffers. This list shows modes for all new buffers. To set modes for individual buffers, use the (toggle-modes) command, or a specific command like (toggle-no-script-mode). |
#3178 might help some of our problems here. |
@lansingthomas How do we feel about being able to collapse/expand each section? We talked about doing that for some specific settings, but maybe it would work well for the whole page? We can use It would look like this: |
Yeeeeeeeeeeah, I think this layout is better than the previous (above).
side tabs:what do you all think?
|
Luka and I spoke on video today, but I will post here in the spirit of transparency. We decided NOT to do :nsection dropdowns -- it sort of hides things on a page where we want users to have a sense of complete understanding (like they can see ALL options). We also talked about how our dropdowns currently are not very good at communicating state. The triangles look pretty similar open and closed. |
@hgluka I think the easiest way to implement it would be to call |
Weaving into the Slightly off-topic: maybe we should make a status buffer button for headings panel/command? It's too useful to be unseen. |
Regarding the implementation (in part responding to @aadcg): I still dislike the intrusive single-letter bindings in the manual and the idea of forcing the panels seems too much to me, but still, I agree with the idea of making Nyxt productivity tools exposed and useful. So I'm on the side of re-using what we already have. That'll also simplify the layout. |
@lansingthomas the question is not how to do it, but rather how to integrate it with existing facilities and practices. Let's focus on getting a prototype as soon as possible, and avoid getting distracted with minor issues that we can addressed later. |
I'm still leaning towards side-tabs of some kind. There's value in showing the user only one, relevant section. As far as the implementation goes, the headings panel was also my first idea, but it might be too cumbersome for this use case. It stays open even when you switch the main buffer, it shows all headings regardless of level, etc. |
Yes, you'd have to modify the headings panel architecture to allow for "sticky" panels that are associated with buffers. This is outside of the scope. Just program it all in HTML only. Do the side tabs design that Thomas has proposed. |
Update: Luka and Tom met today -- here are the actionable items.
|
We also decided to allow special descriptions (written for the common settings page specifically, very human readable) for the other headings/subheadings:
|
Purpose of request:
Luka has been working on updating the common settings page -- this is a draft layout we developed together last week to put his work all together.
The purpose of the layout is to look consistent and professional... and just be better :)
I am aware of a few other open issues related to this:
#2351
#2296
We have been looking at those, and though this post is mostly for Luka -- @aadcg @jmercouris @aartaka, if you have ideas about the common settings page -- speak up.
Describe your proposed change:
Why do you believe this to be an improvement?
We will be adding more things to this page as time goes on. So today we are creating some places for those new things to exist, and clarifying /fixing what already exists on the page.
Additional context/User story:
Luka and I talked about 4 other sections for this page: Privacy/Security Settings, Text/Code Editing Settings, System Settings, Search Settings
These sections are a bit more involved so let's not worry about them (yet... but soon we will).
Screenshots/Mock ups:
common settings light theme layout
common settings dark theme layout
common settings spacing guide
common settings color guide
NOTE: issue #3134 (recently assigned to @aartaka ) involves creating similar checkboxes. Let's try to make them match.
: D
Thanks Luka!
Pre-Build Checklist:
The text was updated successfully, but these errors were encountered: